Skip to content

Conversation

@selenium-ci
Copy link
Member

@selenium-ci selenium-ci commented Oct 21, 2025

User description

This PR contains the results of the autoscaling tests in Kubernetes


PR Type

Other


Description

  • Updated autoscaling test results across six Kubernetes test scenarios

  • Modified metrics include session creation times, pod scaling counts, and gap values

  • Test data reflects new execution runs with varying performance characteristics


Diagram Walkthrough

flowchart LR
  A["Test Execution"] --> B["Autoscaling Metrics"]
  B --> C["Deployment Count Tests"]
  B --> D["Job Count Tests"]
  B --> E["Chaos Scenario Tests"]
  C --> F["Updated Results"]
  D --> F
  E --> F
Loading

File Walkthrough

Relevant files
Test results
results_test_k8s_autoscaling_deployment_count.md
Deployment count autoscaling test results updated               

.keda/results_test_k8s_autoscaling_deployment_count.md

  • Updated all 20 iteration rows with new test execution metrics
  • Modified session creation times ranging from 0.11s to 247.34s
  • Adjusted pod scaling counts with some negative values indicating
    scale-down events
  • Updated gap values reflecting pod availability during test iterations
+20/-20 
results_test_k8s_autoscaling_deployment_count_in_chaos.md
Deployment count chaos scenario test results updated         

.keda/results_test_k8s_autoscaling_deployment_count_in_chaos.md

  • Refreshed all 20 iteration metrics for chaos scenario testing
  • Modified session creation times and pod scaling behavior under chaos
    conditions
  • Updated total running pods and gap metrics across all iterations
  • Adjusted session closure counts reflecting chaos impact on workload
+20/-20 
results_test_k8s_autoscaling_deployment_count_with_node_max_sessions.md
Deployment count with node max sessions test results updated

.keda/results_test_k8s_autoscaling_deployment_count_with_node_max_sessions.md

  • Updated all 20 iterations with new metrics for node max sessions
    constraint
  • Modified session creation times and pod scaling with max sessions per
    pod set to 3
  • Adjusted gap values reflecting constrained pod capacity scenarios
  • Updated total running pods and sessions closed metrics
+20/-20 
results_test_k8s_autoscaling_job_count_strategy_default.md
Job count default strategy autoscaling test results updated

.keda/results_test_k8s_autoscaling_job_count_strategy_default.md

  • Refreshed all 20 iteration rows with new job count strategy test
    metrics
  • Modified session creation times and pod scaling counts for default
    strategy
  • Updated total running sessions and pods across all test iterations
  • Adjusted gap values reflecting job-based autoscaling behavior
+20/-20 
results_test_k8s_autoscaling_job_count_strategy_default_in_chaos.md
Job count default strategy chaos scenario test results updated

.keda/results_test_k8s_autoscaling_job_count_strategy_default_in_chaos.md

  • Updated all 20 iterations for job count strategy under chaos
    conditions
  • Modified session creation times with some very fast iterations (0.06s,
    0.15s)
  • Adjusted pod scaling and session metrics reflecting chaos impact on
    job strategy
  • Updated total running sessions and pods for chaos scenario
+20/-20 
results_test_k8s_autoscaling_job_count_strategy_default_with_node_max_sessions.md
Job count strategy with node max sessions test results updated

.keda/results_test_k8s_autoscaling_job_count_strategy_default_with_node_max_sessions.md

  • Refreshed all 20 iterations with job count strategy and node max
    sessions constraint
  • Modified session creation times and pod scaling with max sessions per
    pod set to 3
  • Updated gap values reflecting constrained capacity in job-based
    scaling
  • Adjusted total running pods and sessions closed metrics
+20/-20 

@qodo-merge-pro
Copy link
Contributor

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
- [ ] Create ticket/issue <!-- /create_ticket --create_ticket=true -->

</details></td></tr>
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
No custom compliance provided

Follow the guide to enable custom compliance check.

Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-merge-pro
Copy link
Contributor

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
High-level
Avoid committing raw test results

Instead of committing raw test result data to the repository, store it in an
external system like an artifact repository. The PR description should then
contain a summary of the results and a link to the raw data.

Examples:

.keda/results_test_k8s_autoscaling_deployment_count.md [1-22]
| Iteration | New request sessions | Sessions created time | Sessions failed to create | New pods scaled up | Total running sessions | Total running pods | Max sessions per pod | Gaps | Sessions closed |
| --------- | -------------------- | --------------------- | ------------------------- | ------------------ | ---------------------- | ------------------ | -------------------- | ---- | --------------- |
| 1         | 2                    | 0.11 s                | 2                         | 0                  | 0                      | 0                  | 1                    | 0    | 0               |
| 2         | 1                    | 30.22 s               | 0                         | 2                  | 1                      | 2                  | 1                    | 1    | 0               |
| 3         | 2                    | 52.83 s               | 0                         | 3                  | 3                      | 5                  | 1                    | 2    | 0               |
| 4         | 2                    | 18.58 s               | 0                         | 2                  | 5                      | 7                  | 1                    | 2    | 0               |
| 5         | 2                    | 46.41 s               | 0                         | 2                  | 7                      | 9                  | 1                    | 2    | 0               |
| 6         | 3                    | 42.93 s               | 0                         | 3                  | 10                     | 12                 | 1                    | 2    | 10              |
| 7         | 2                    | 45.67 s               | 0                         | 1                  | 2                      | 13                 | 1                    | 11   | 0               |
| 8         | 1                    | 14.83 s               | 0                         | 0                  | 3                      | 13                 | 1                    | 10   | 0               |

 ... (clipped 12 lines)
.keda/results_test_k8s_autoscaling_deployment_count_in_chaos.md [1-22]
| Iteration | New request sessions | Sessions created time | Sessions failed to create | New pods scaled up | Total running sessions | Total running pods | Max sessions per pod | Gaps | Sessions closed |
| --------- | -------------------- | --------------------- | ------------------------- | ------------------ | ---------------------- | ------------------ | -------------------- | ---- | --------------- |
| 1         | 5                    | 0.12 s                | 5                         | 0                  | 0                      | 0                  | 1                    | 0    | 0               |
| 2         | 3                    | 58.06 s               | 0                         | 5                  | 3                      | 5                  | 1                    | 2    | 3               |
| 3         | 3                    | 48.64 s               | 0                         | 1                  | 3                      | 6                  | 1                    | 3    | 3               |
| 4         | 6                    | 46.75 s               | 0                         | 2                  | 6                      | 8                  | 1                    | 2    | 3               |
| 5         | 3                    | 18.12 s               | 0                         | 1                  | 6                      | 9                  | 1                    | 3    | 6               |
| 6         | 4                    | 10.21 s               | 0                         | 0                  | 4                      | 9                  | 1                    | 5    | 4               |
| 7         | 3                    | 15.63 s               | 0                         | 0                  | 3                      | 9                  | 1                    | 6    | 3               |
| 8         | 5                    | 14.89 s               | 0                         | 0                  | 5                      | 9                  | 1                    | 4    | 5               |

 ... (clipped 12 lines)

Solution Walkthrough:

Before:

# PR updates raw data files directly in the git repository.
# .keda/results_test_k8s_autoscaling_deployment_count.md

| Iteration | New request sessions | Sessions created time | ... |
| --------- | -------------------- | --------------------- | --- |
| 1         | 2                    | 0.11 s                | ... |
| 2         | 1                    | 30.22 s               | ... |
| ...       | ...                  | ...                   | ... |
| 20        | 1                    | 18.03 s               | ... |

# This pattern is repeated for all 6 result files.

After:

# PR description contains a summary and a link to external storage.
# The raw data files are not committed to the repository.

PR Description:
"
### Autoscaling Test Results

**Summary of key changes:**
- Deployment count test: Average session creation time changed from X to Y.
- Chaos test: Pod scaling is now 15% more responsive.

**Raw data:**
The complete test results can be found in our artifact storage: [link-to-results]
"
Suggestion importance[1-10]: 7

__

Why: This is a valid and important suggestion regarding repository health and best practices, addressing the entire scope of the PR, though it's a process change rather than a code correction.

Medium
  • More

@VietND96 VietND96 self-requested a review October 21, 2025 11:31
@VietND96 VietND96 merged commit af2c624 into trunk Oct 21, 2025
1 check passed
@VietND96 VietND96 deleted the autoscaling-results branch October 21, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants